mptyl/ThothII
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(frontend): English chrome labels in schema-linking gate (Promote/Exclude/Columns)

Browse Source
This commit is contained in:
marcopan
2026-07-06 23:25:00 +02:00
committed by Marco Pancotti
parent 40a0395a70
commit b6397bd965
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/widgets/SchemaLinkingGateWidget.test.tsx
+2 -2
View File
@@ -50,8 +50,8 @@ test("Confirm emits enacted tables with suggested columns (catalog order)", asyn
test("selecting a column in the modal adds it to the response", async () => {
const onRespond = vi.fn();
render(<SchemaLinkingGateWidget descriptor={descriptor} onRespond={onRespond} />);
// dim_patient starts with 1 suggested of 2 -> its button reads "Colonne 1/2".
await userEvent.click(screen.getByRole("button", { name: /colonne 1\/2/i }));
// dim_patient starts with 1 suggested of 2 -> its button reads "Columns 1/2".
await userEvent.click(screen.getByRole("button", { name: /columns 1\/2/i }));
await userEvent.click(screen.getByRole("checkbox", { name: "nome" }));
await userEvent.click(screen.getByRole("button", { name: /close/i })); // dialog X button
await userEvent.click(screen.getByRole("button", { name: /confirm/i }));
frontend/src/widgets/SchemaLinkingGateWidget.tsx
+2 -2
View File
@@ -81,7 +81,7 @@ export function SchemaLinkingGateWidget({ descriptor, onRespond }: WidgetProps)
<div className="min-w-0 flex-1">
<div className="flex items-center gap-2">
<span className="font-mono text-sm font-semibold text-foreground">{t.name}</span>
<span className="thot-label">{t.kind === "promote" ? "Promuovi" : "Escludi"}</span>
<span className="thot-label">{t.kind === "promote" ? "Promote" : "Exclude"}</span>
</div>
{t.description && <p className="mt-0.5 text-sm text-muted-foreground">{t.description}</p>}
{t.rationale && <p className="mt-0.5 text-sm text-foreground/80">{t.rationale}</p>}
@@ -90,7 +90,7 @@ export function SchemaLinkingGateWidget({ descriptor, onRespond }: WidgetProps)
className="shrink-0 self-center rounded-md border border-border/60 px-2.5 py-1 text-xs text-muted-foreground shadow-xs transition-colors hover:bg-muted hover:text-foreground"
onClick={() => setOpenId(t.id)}
>
{t.kind === "promote" ? `Colonne ${count}/${t.columns.length}` : `Colonne ${t.columns.length}`}
{t.kind === "promote" ? `Columns ${count}/${t.columns.length}` : `Columns ${t.columns.length}`}
</button>
</div>
</div>