marcopanandClaude Opus 4.8
c4d130828f
Implementazione del piano di remediation progressiva sui difetti emersi dall'analisi dell'harness. Tutto verificato: 214 test Python (incl. L0 su Postgres reale), 14 test JS del gate, ruff pulito. Blocco 1 (CRITICA, integrazione gate↔CLI): - phase advance: gate usa --auto + exit 6; reviewer_confirm kind:phase fa advance esplicito che applica i prerequisiti (prima non avanzava per le fasi a conferma umana). - cte plan riceve i --name dal gate (param names); set-question con id posizionale; skill `tht search find`; nuovo comando `tht memory save-one` con dedup hash client-side in save_one_memory. Blocco 2 (D15, stato post-rollback): - campo `phase` su DecisionRecord + effective_decisions phase-aware per i subject "a nome" (cte_approved ecc.); _compute_promotions e finalize sulla vista effective; finalize confronta col piano CTE effettivo, non glob; `decision add --retracts` + comando `decision retract`. Blocco 3 (D7 read-only + D6 manifest): - assert_read_only su tutti e quattro i codepath (direct + REST); - manifest author/summary/updated_at/updated_by/schema_version popolati + helper touch_manifest sulle mutazioni. Blocco 4-5 (D14a/D14b): - decision_min_phase data-driven via `emits:` in workflow.yaml; - formula evidence: status auto, search_formulas, gruppo CLI `tht formula`, `search find --kind formula`, load_evidence_dir salta i .sql.md. Blocco 6 (robustezza): - taskdoc slice promoted_tables + bound enforced; report escaping/bound + rsplit note; filtro kind reader REST/direct; conteggio upserted robusto; guard REST run_query non-list; LSH disallineato -> LshIndexError. Blocco 7 (pulizia): - dead code gate e KIND_TO_TABLE morto rimossi; doc Postgres-only (README + connection.py). Blocco 0 (parziale): test di compatibilità firma gate↔CLI (tests/integration). Rinviati: fake-Pi runtime completo, artifact-gate da disco (#23), parità eligibility REST/direct (#28), unificazione reserved-labels (#30), memory_rejected da deselezione (#33). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
47 lines
1.9 KiB
Python
47 lines
1.9 KiB
Python
"""D15 granularity (a): `tht decision retract` tombstones the last substantive decision.
|
|
|
|
Wires the step-granularity rollback ("re-ask current widget, discard last answer") to a
|
|
reachable CLI command. The data model (decision_retracted + retracts, honored by
|
|
effective_decisions) already existed; this pins the command that emits it.
|
|
"""
|
|
from pathlib import Path
|
|
|
|
from tht.cli.decision_cmd import retract_cmd
|
|
from tht.decisions import append_decision, list_decisions
|
|
from tht.phase import current_phase, effective_decisions
|
|
|
|
|
|
def _walk_to_phase(session: Path, target: int) -> None:
|
|
while current_phase(session) < target:
|
|
append_decision(session, type="phase_approved", subject=f"phase:{current_phase(session)}")
|
|
|
|
|
|
def test_retract_drops_last_substantive_decision(tmp_path, monkeypatch):
|
|
s = tmp_path / "2026-01-01-000000-x"
|
|
s.mkdir(parents=True)
|
|
_walk_to_phase(s, 4)
|
|
append_decision(s, type="table_promoted", subject="phase:4", detail="dim_pazienti")
|
|
append_decision(s, type="table_promoted", subject="phase:4", detail="fact_ricoveri")
|
|
|
|
# stub config + session loading (the command only needs a session dir)
|
|
import tht.cli.decision_cmd as mod
|
|
|
|
class _Cfg:
|
|
class paths:
|
|
sessions = tmp_path
|
|
|
|
monkeypatch.setattr(mod, "_load_config_or_exit", lambda _c: _Cfg())
|
|
monkeypatch.setattr(mod, "load_session_or_exit", lambda _cfg, _s: None)
|
|
monkeypatch.setattr(mod, "session_dir", lambda _cfg, sid: tmp_path / sid)
|
|
|
|
retract_cmd(session="2026-01-01-000000-x", config=Path("x"))
|
|
|
|
eff = effective_decisions(s)
|
|
promoted = [d for d in eff if d.type == "table_promoted"]
|
|
assert len(promoted) == 1 # the last one was retracted
|
|
assert promoted[0].detail == "dim_pazienti"
|
|
# the audit log keeps everything (append-only): 2 promotions + the retract marker
|
|
raw = [d.type for d in list_decisions(s)]
|
|
assert raw.count("table_promoted") == 2
|
|
assert "decision_retracted" in raw
|