marcopan
fbcd694ace
- ported from ChironeWp3 (22 DecisionType, append-only jsonl, monotonic seq) - added decision_retracted type + retracts field for step-level rollback (D15): the retracted decision stays in the audit log, effective_decisions() (Task A5) will exclude it from the active view - 5 tests: retract marker + monotonic seq + retracts default + empty session + literal includes retracted. All 13 harness tests pass.
67 lines
2.4 KiB
Python
67 lines
2.4 KiB
Python
from nsp.decisions import append_decision, list_decisions
|
|
|
|
|
|
def test_decision_retracted_in_audit_but_marked(tmp_path):
|
|
"""Una decisione ritirata resta nel log di audit (append-only) ma porta il marker."""
|
|
session = tmp_path / "s1"
|
|
session.mkdir()
|
|
d1 = append_decision(
|
|
session, type="table_promoted", subject="phase:4", detail="t1", rationale="r"
|
|
)
|
|
d2 = append_decision(
|
|
session,
|
|
type="decision_retracted",
|
|
subject="phase:4",
|
|
detail="wrong answer, retry",
|
|
rationale="user picked back",
|
|
retracts=d1.seq,
|
|
)
|
|
all_decisions = list_decisions(session)
|
|
assert len(all_decisions) == 2 # entrambe nel log di audit
|
|
assert all_decisions[0].seq == 1
|
|
assert all_decisions[0].type == "table_promoted"
|
|
assert all_decisions[1].seq == 2
|
|
assert all_decisions[1].type == "decision_retracted"
|
|
assert all_decisions[1].retracts == 1 # marker verso la decisione ritirata
|
|
|
|
|
|
def test_append_decision_assigns_monotonic_seq(tmp_path):
|
|
session = tmp_path / "s2"
|
|
session.mkdir()
|
|
d1 = append_decision(session, type="phase_approved", subject="phase:1")
|
|
d2 = append_decision(session, type="phase_approved", subject="phase:2")
|
|
d3 = append_decision(session, type="question_rewritten", subject="phase:3", detail="new q")
|
|
assert (d1.seq, d2.seq, d3.seq) == (1, 2, 3)
|
|
assert d3.detail == "new q"
|
|
# re-read from disk: seq preserved
|
|
loaded = list_decisions(session)
|
|
assert [d.seq for d in loaded] == [1, 2, 3]
|
|
|
|
|
|
def test_retracts_defaults_none(tmp_path):
|
|
"""Le decisioni normali hanno retracts=None (non serializzato come null rumoroso)."""
|
|
session = tmp_path / "s3"
|
|
session.mkdir()
|
|
d = append_decision(session, type="concept_clarified", subject="phase:1", detail="x")
|
|
assert d.retracts is None
|
|
# round-trip via JSON
|
|
loaded = list_decisions(session)
|
|
assert loaded[0].retracts is None
|
|
|
|
|
|
def test_empty_session_returns_empty_list(tmp_path):
|
|
session = tmp_path / "empty"
|
|
session.mkdir()
|
|
assert list_decisions(session) == []
|
|
|
|
|
|
def test_decision_type_literal_includes_retracted():
|
|
"""decision_retracted e' un tipo valido (pydantic lo accetta)."""
|
|
from nsp.decisions import DecisionRecord
|
|
from datetime import datetime, UTC
|
|
d = DecisionRecord(
|
|
seq=1, ts=datetime.now(UTC), type="decision_retracted",
|
|
subject="phase:4", retracts=1,
|
|
)
|
|
assert d.type == "decision_retracted"
|