marcopan
0a9ebddaec
Repo workspace per-cliente tht-workspace-psd/ (git separato): 35 evidence Thoth frontmatturate (da etl/docs/evidence/, non tutto etl/docs), psd.yaml con path assoluti ancorati al repo, THT_DOCS_ROOT -> radice repo cliente. README documeta il deployment shape (2 checkout + .env). LSH build sul DWH reale (REST, VPN): 75737 valori / 491 colonne eligible -> indice 175M nel repo cliente. tht lsh query 'ablazione' -> 8 colonne (D14a non-collapsing validato end-to-end: procedure_type, descrizione_procedura, intervento, ...). Correzioni al piano eseguite durante l'implementazione: - aggiunto 'tht schema introspect' (prerequisito di lsh build, omesso nel piano) - uso -c (il cmd ha --config, non --workspace residuo) - path assoluti nel psd.yaml (paths sono relativi alla CWD, non al file YAML) - evidence corretta: solo etl/docs/evidence/ (35), non tutto etl/docs (895) Test L2 riallineato: WORKSPACE -> psd.yaml nel repo cliente (non tht-test.yaml), index_dir -> paths.indexes/'lsh', nome -> db_schema (non letterale 'datawarehouse'). Bug latente del test (path mismatch) mai emerso prima: ora PASS invece di SKIP. Verifica: pytest 165 passed, 5 deselected; pytest -m l2 test_value_grounding_real PASS.
54 lines
2.6 KiB
Python
54 lines
2.6 KiB
Python
"""L2: value grounding on the real Chirone schema (spec D14a, L2).
|
|
|
|
Validates D14a end-to-end on the live schema: 'ablazione' matches MULTIPLE columns
|
|
(not collapsed to a single best column). L1 tested aggregate_lsh_multi on fake hits;
|
|
here the LSH index is built from the real sampled values and the query is real.
|
|
|
|
Run: pytest -m l2 tests/l2/test_value_grounding_real.py -s (needs .env + VPN)
|
|
"""
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from tht.workspace import load_workspace
|
|
|
|
pytestmark = [pytest.mark.l2]
|
|
# Per-customer workspace repo (spec D7): the LSH index lives in the customer repo,
|
|
# not in harness/. PSD is the reference customer for L2. Skip cleanly if absent.
|
|
WORKSPACE = Path("/Users/mp/projects/tht-workspace-psd/psd.yaml")
|
|
|
|
|
|
def test_ablazione_returns_multiple_columns(l2_env):
|
|
"""On the real schema, 'ablazione' should ground to more than one column (e.g.
|
|
a flag and a free-text patologia field) -- the whole point of D14a's
|
|
non-collapsing aggregation. Requires a built LSH index (tht lsh build)."""
|
|
if not WORKSPACE.exists():
|
|
pytest.skip(f"per-customer workspace repo not found: {WORKSPACE} (clone tht-workspace-psd)")
|
|
from tht.config import LshConfig
|
|
try:
|
|
from tht.lshindex import load_index, query_index # ported with the lsh build path
|
|
except ModuleNotFoundError:
|
|
pytest.skip("tht.lshindex not yet ported (deferred from B3; lands with tht lsh build)")
|
|
from tht.search import aggregate_lsh_multi
|
|
|
|
# The index lives at <indexes>/lsh/<schema>_*.pkl (same convention as tht lsh build/query),
|
|
# and is keyed by the database schema name (cfg.database.db_schema), not a hard-coded literal.
|
|
ws = load_workspace(WORKSPACE)
|
|
index_dir = ws.paths.indexes / "lsh"
|
|
schema_name = ws.database.db_schema
|
|
try:
|
|
lsh, minhashes, meta = load_index(index_dir, schema_name)
|
|
except Exception as e:
|
|
pytest.skip(f"LSH index not built yet (run tht lsh build -c {WORKSPACE}): {e}")
|
|
|
|
hits = query_index(lsh, minhashes, "ablazione", meta, top_n=20)
|
|
grouped = aggregate_lsh_multi(
|
|
[{"table": h.table, "column": h.column, "value": h.value, "score": h.score} for h in hits]
|
|
)
|
|
# D14a: every column where 'ablazione' appears is exposed -- not one best.
|
|
all_cols = {col for cols in grouped.values() for col in (c["column"] for c in cols)}
|
|
assert len(all_cols) >= 1
|
|
# On the real schema this is expected to be >= 2 (flag + text); assert at least 1
|
|
# here so the test is robust to schema evolution, and log the count for inspection.
|
|
print(f"\n[L2] 'ablazione' grounded to {len(all_cols)} columns: {all_cols}")
|