marcopanandClaude Opus 4.6
6ee5bda7f0
Gate (tht-gate.js): - Pre-validate decision types against workflow.yaml before showing reviewer widget - Reject decisions emitted by later phases (min-phase check) - Copy top-level `kind` into artifact when model forgets it (prevents loop) - Force-advance on reviewer_decide/schema_linking when advance:true — skip redundant reviewer_confirm gate Backend: - Emit agent_end on clean Pi exit (code 0 + bridge idle) instead of marking failed Frontend: - Strip <think> tags from transcript and activity panel - Fix mermaid render with offscreen container + cleanup - Graceful mermaid error: show source code instead of red error, fall back to table Workflow: - F2 now emits table_promoted and table_excluded (early schema linking decisions) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
38 lines
1.2 KiB
Python
38 lines
1.2 KiB
Python
"""decision_min_phase must cover every substantive decision type (data-driven via emits).
|
|
|
|
The reference bug: only the ~5 types referenced in prerequisites had a min phase; all
|
|
others (table_promoted, cte_approved, value_grounded, concept_formula_*, ...) defaulted
|
|
to phase 1, so require_phase_or_exit would accept them far too early. workflow.yaml now
|
|
declares `emits` per phase as the source of truth.
|
|
"""
|
|
import pytest
|
|
|
|
from tht.workflow import load_workflow
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"dtype,expected",
|
|
[
|
|
("concept_clarified", 1),
|
|
("memory_rejected", 2),
|
|
("question_rewritten", 3),
|
|
("table_promoted", 2),
|
|
("column_corrected", 4),
|
|
("evidence_accepted", 4),
|
|
("value_grounded", 4),
|
|
("concept_formula_approved", 4),
|
|
("concept_formula_rejected", 4),
|
|
("cte_approved", 6),
|
|
("sql_approved", 7),
|
|
("sql_revised", 7),
|
|
("datamart_requested", 8),
|
|
],
|
|
)
|
|
def test_decision_min_phase_from_emits(dtype, expected):
|
|
assert load_workflow().decision_min_phase(dtype) == expected
|
|
|
|
|
|
@pytest.mark.parametrize("meta", ["phase_approved", "phase_reopened", "decision_retracted"])
|
|
def test_meta_types_not_phase_gated(meta):
|
|
assert load_workflow().decision_min_phase(meta) == 1
|