marcopan
c861a0df9e
Pre-release, non-deterministic tests (marker l2, skipped without .env + VPN). They
close the gaps L1 leaves open: real value grounding on the live schema, real memory
save-one upsert to pgvector, and the full GLM 5.2 -> gate conversation on the
'ablazione' question (which exercises D14 value grounding + formula on a multi-
column case + the gate glue L1 cannot reach).
workspaces/chirone-test.yaml points at the remote endpoints (DWH read-only +
pgvector dual-key, TLS self-signed); secrets via ${THOTH_*}.
- test_session_ablazione: precondition checks (workspace loads, env present, pi on
PATH) + the documented manual run protocol (human-in-the-loop; scripted-answers
variant is a follow-up). Default run skips cleanly.
- test_value_grounding_real: 'ablazione' grounds to multiple columns on the real
schema (D14a non-collapsing), needs a built LSH index.
- test_memory_save_one_real: save_one_memory upserts one row via the writer key
(D11) and search_similar retrieves it via the reader key.
Operator runs before release (pytest -m l2). Default run: 109 passed, 5 skipped.
51 lines
2.2 KiB
Python
51 lines
2.2 KiB
Python
"""L2: nsp memory save-one against real pgvector (spec D11, L2).
|
|
|
|
Validates D11 end-to-end: a single promoted decision is upserted to the real
|
|
pgvector via the WRITER key (not a full resync), and a subsequent search_similar
|
|
finds the memory. L1 tested the pure save_one_memory core; here the REST writer +
|
|
real pgvector + real embeddings are in the loop.
|
|
|
|
Run: pytest -m l2 tests/l2/test_memory_save_one_real.py -s (needs .env + VPN + Ollama)
|
|
"""
|
|
from datetime import datetime
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from nsp.memory import MemoryRecord, save_one_memory
|
|
from nsp.workspace import load_workspace
|
|
|
|
pytestmark = [pytest.mark.l2]
|
|
WORKSPACE = Path(__file__).resolve().parents[2] / "workspaces" / "chirone-test.yaml"
|
|
|
|
|
|
def test_save_one_upserts_to_real_pgvector(l2_env):
|
|
"""save_one_memory pushes one row to the real pgvector via the writer key, and
|
|
a subsequent search_similar retrieves it. Idempotent (re-running upserts >= 0)."""
|
|
from nsp.vectorstore.embeddings import OllamaEmbeddings
|
|
from nsp.vectorstore.rest_client import VectorRestClient
|
|
|
|
ws = load_workspace(WORKSPACE)
|
|
if not ws.vector_db.write_rest or not ws.vector_db.write_rest.api_key.strip():
|
|
pytest.skip("vector_db.write_rest not configured (no writer key)")
|
|
|
|
writer = VectorRestClient(ws.vector_db.write_rest)
|
|
embedder = OllamaEmbeddings(ws.embeddings)
|
|
|
|
record = MemoryRecord(
|
|
id="mem-l2test", ts=datetime.now(), session_id="l2-self-test",
|
|
decision_seq=999, type="table_promoted", subject="fct_ricoveri",
|
|
detail="ablazione", rationale="L2 self-test (idempotent)",
|
|
question_context="ablazione 2025", tables=["fct_ricoveri"], concepts=[],
|
|
)
|
|
upserted = save_one_memory([record], decision_seq=999, writer=writer, embedder=embedder)
|
|
assert upserted >= 0 # idempotent: 0 on unchanged, >=1 on new/updated
|
|
|
|
# read it back via the READER key
|
|
reader = VectorRestClient(ws.vector_db.rest)
|
|
qvec = embedder.embed_query("ablazione")
|
|
hits = reader.search_similar("memory", qvec, 10)
|
|
ids = {h.get("metadata", {}).get("record_key", "") for h in hits}
|
|
assert "memory:mem-l2test" in ids, "upserted memory not retrievable via search_similar"
|