marcopanandClaude Opus 4.8
c4d130828f
Implementazione del piano di remediation progressiva sui difetti emersi dall'analisi dell'harness. Tutto verificato: 214 test Python (incl. L0 su Postgres reale), 14 test JS del gate, ruff pulito. Blocco 1 (CRITICA, integrazione gate↔CLI): - phase advance: gate usa --auto + exit 6; reviewer_confirm kind:phase fa advance esplicito che applica i prerequisiti (prima non avanzava per le fasi a conferma umana). - cte plan riceve i --name dal gate (param names); set-question con id posizionale; skill `tht search find`; nuovo comando `tht memory save-one` con dedup hash client-side in save_one_memory. Blocco 2 (D15, stato post-rollback): - campo `phase` su DecisionRecord + effective_decisions phase-aware per i subject "a nome" (cte_approved ecc.); _compute_promotions e finalize sulla vista effective; finalize confronta col piano CTE effettivo, non glob; `decision add --retracts` + comando `decision retract`. Blocco 3 (D7 read-only + D6 manifest): - assert_read_only su tutti e quattro i codepath (direct + REST); - manifest author/summary/updated_at/updated_by/schema_version popolati + helper touch_manifest sulle mutazioni. Blocco 4-5 (D14a/D14b): - decision_min_phase data-driven via `emits:` in workflow.yaml; - formula evidence: status auto, search_formulas, gruppo CLI `tht formula`, `search find --kind formula`, load_evidence_dir salta i .sql.md. Blocco 6 (robustezza): - taskdoc slice promoted_tables + bound enforced; report escaping/bound + rsplit note; filtro kind reader REST/direct; conteggio upserted robusto; guard REST run_query non-list; LSH disallineato -> LshIndexError. Blocco 7 (pulizia): - dead code gate e KIND_TO_TABLE morto rimossi; doc Postgres-only (README + connection.py). Blocco 0 (parziale): test di compatibilità firma gate↔CLI (tests/integration). Rinviati: fake-Pi runtime completo, artifact-gate da disco (#23), parità eligibility REST/direct (#28), unificazione reserved-labels (#30), memory_rejected da deselezione (#33). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
38 lines
1.2 KiB
Python
38 lines
1.2 KiB
Python
"""decision_min_phase must cover every substantive decision type (data-driven via emits).
|
|
|
|
The reference bug: only the ~5 types referenced in prerequisites had a min phase; all
|
|
others (table_promoted, cte_approved, value_grounded, concept_formula_*, ...) defaulted
|
|
to phase 1, so require_phase_or_exit would accept them far too early. workflow.yaml now
|
|
declares `emits` per phase as the source of truth.
|
|
"""
|
|
import pytest
|
|
|
|
from tht.workflow import load_workflow
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"dtype,expected",
|
|
[
|
|
("concept_clarified", 1),
|
|
("memory_rejected", 2),
|
|
("question_rewritten", 3),
|
|
("table_promoted", 4),
|
|
("column_corrected", 4),
|
|
("evidence_accepted", 4),
|
|
("value_grounded", 4),
|
|
("concept_formula_approved", 4),
|
|
("concept_formula_rejected", 4),
|
|
("cte_approved", 6),
|
|
("sql_approved", 7),
|
|
("sql_revised", 7),
|
|
("datamart_requested", 8),
|
|
],
|
|
)
|
|
def test_decision_min_phase_from_emits(dtype, expected):
|
|
assert load_workflow().decision_min_phase(dtype) == expected
|
|
|
|
|
|
@pytest.mark.parametrize("meta", ["phase_approved", "phase_reopened", "decision_retracted"])
|
|
def test_meta_types_not_phase_gated(meta):
|
|
assert load_workflow().decision_min_phase(meta) == 1
|