mptyl/ThothII
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: give the patients fixture a same-name primary key column

Browse Source
This commit is contained in:
marcopan
2026-08-11 19:44:30 +02:00
parent f00cc289d8
commit ff75742be9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/scripts/p2-acceptance.mjs
+3 -3
View File
@@ -462,8 +462,8 @@ async function setupFixtures(ctx) {
patients: { patients: {
comment: "Patients", comment: "Patients",
rows: [ rows: [
{ id: "p1", name: "Alice" }, { patient_id: "p1", name: "Alice" },
{ id: "p2", name: "Bob" }, { patient_id: "p2", name: "Bob" },
], ],
}, },
visits: { visits: {
@@ -1169,7 +1169,7 @@ async function realChecks(ctx) {
// approved SQL joins for candidates. // approved SQL joins for candidates.
await runThothctlJson(ctx, "preprocess-dwh-filesystem", ["workspace", "preprocess", "dwh", "--workspace", "p2-filesystem"], 0); await runThothctlJson(ctx, "preprocess-dwh-filesystem", ["workspace", "preprocess", "dwh", "--workspace", "p2-filesystem"], 0);
const sqlPath = join(ctx.run.root, "fixtures", "p2-filesystem.sql"); const sqlPath = join(ctx.run.root, "fixtures", "p2-filesystem.sql");
await atomicWrite(sqlPath, "SELECT v.id FROM dw.visits v JOIN dw.patients p ON v.patient_id = p.id\n"); await atomicWrite(sqlPath, "SELECT v.id FROM dw.visits v JOIN dw.patients p ON v.patient_id = p.patient_id\n");
const suggest = await runThothctlJson(ctx, "schema-suggest-filesystem", ["workspace", "schema", "suggest-fks", "--workspace", "p2-filesystem", "--from-sql", sqlPath], 3); const suggest = await runThothctlJson(ctx, "schema-suggest-filesystem", ["workspace", "schema", "suggest-fks", "--workspace", "p2-filesystem", "--from-sql", sqlPath], 3);
assert(suggest.payload.code === "manual_review_required", "suggest did not block"); assert(suggest.payload.code === "manual_review_required", "suggest did not block");
assert(typeof suggest.payload.suggestedFksYaml === "string" && suggest.payload.suggestedFksYaml.length > 0, "suggested FK YAML missing"); assert(typeof suggest.payload.suggestedFksYaml === "string" && suggest.payload.suggestedFksYaml.length > 0, "suggested FK YAML missing");