fix(vector): separate write transport fields

2026-07-11 20:35:57 +02:00
parent ff4d662aba
commit fe8d70da47
6 changed files with 117 additions and 26 deletions
@@ -163,7 +163,8 @@ git commit -m "refactor(dwh): adapt direct and REST transports"
 - Modify: `harness/tht/vectorstore/reader.py`

 **Interfaces:**
- Produces: `VectorStore`, `VectorCapabilities`, `VectorHealth`, `VectorRecord`, `VectorHit`, `ThothHttpVectorStore`.
+- Produces: `VectorStore`, `VectorCapabilities`, `VectorHealth`, `VectorRecord`,
+  `VectorWriteRecord`, `VectorHit`, `ThothHttpVectorStore`.
 - Preserves: current `VectorRestClient`, `DirectSearcher`, and `RestSearcher` behavior behind wrappers.

 - [ ] **Step 1: Write read/write capability and dual-credential tests**
@@ -193,9 +194,13 @@ class VectorStore(Protocol):
    def search(self, collections: list[str], embedding: list[float], *, limit: int,
               kinds: list[str] | None = None) -> list[VectorHit]: ...
    def existing_hashes(self, collection: str, kinds: list[str]) -> dict[str, str]: ...
-    def upsert(self, collection: str, records: list[VectorRecord]) -> int: ...
+    def upsert(self, collection: str, records: list[VectorWriteRecord]) -> int: ...
 ```

+`VectorWriteRecord` is the transport-neutral write envelope: it contains the canonical
+`VectorRecord`, a precomputed embedding, and a content hash. Adapters must preserve
+`VectorRecord.metadata` unchanged, including semantic keys named `embedding` or `content_hash`.
+
 - [ ] **Step 4: Run vector regression tests**

 Run: `cd harness && .venv/bin/pytest tests/test_vector_port_contract.py tests/test_vector_dual_key.py tests/test_search_similar_kinds.py tests/test_memory_save_one.py tests/test_solved_question.py -q`