refactor(core): route integrations through adapter factory

2026-07-11 20:52:41 +02:00
parent 1e0911bb6a
commit dbbab6d005
8 changed files with 245 additions and 105 deletions
@@ -0,0 +1,86 @@
+import pytest
+
+from tht.adapters.dwh import PostgresDwhAdapter, ThothRestDwhAdapter
+from tht.adapters.vector import LegacyDirectVectorStore, ThothHttpVectorStore
+from tht.adapters.factory import build_dwh, build_vector_store
+from tht.config import Config, ConfigError
+
+
+def _config(*, dwh_type="thoth_rest", vector_type="thoth_vector_http", writer=True):
+    dwh = (
+        {
+            "type": "thoth_rest",
+            "database": {"database": "analytics", "schema": "mart"},
+            "endpoint": {"base_url": "https://dwh.test/", "api_key": "reader"},
+        }
+        if dwh_type == "thoth_rest"
+        else {
+            "type": "postgres_direct",
+            "connection": {
+                "host": "db",
+                "database": "analytics",
+                "schema": "mart",
+                "user": "reader",
+                "password": "secret",
+            },
+        }
+    )
+    vectors = (
+        {
+            "type": "thoth_vector_http",
+            "reader": {"base_url": "https://vectors.test/", "api_key": "reader"},
+            **(
+                {"writer": {"base_url": "https://vectors.test/", "api_key": "writer"}}
+                if writer
+                else {}
+            ),
+        }
+        if vector_type == "thoth_vector_http"
+        else {
+            "type": "pgvector_direct",
+            "connection": {
+                "host": "vector-db",
+                "database": "postgres",
+                "schema": "vectors",
+                "user": "reader",
+                "password": "secret",
+            },
+        }
+    )
+    legacy_database = (
+        dwh["connection"]
+        if dwh_type == "postgres_direct"
+        else {
+            **dwh["database"],
+            "user": "rest",
+            "password": "",
+            "transport": "rest",
+        }
+    )
+    return Config.model_validate(
+        {"dwh": dwh, "vectors": vectors, "database": legacy_database}
+    )
+
+
+@pytest.mark.parametrize(
+    ("dwh_type", "adapter_type"),
+    [("postgres_direct", PostgresDwhAdapter), ("thoth_rest", ThothRestDwhAdapter)],
+)
+def test_factory_selects_dwh_adapter(dwh_type, adapter_type):
+    assert isinstance(build_dwh(_config(dwh_type=dwh_type)), adapter_type)
+
+
+def test_factory_selects_http_vector_and_requires_writer():
+    config = _config(writer=False)
+
+    assert isinstance(build_vector_store(config), ThothHttpVectorStore)
+    with pytest.raises(ConfigError, match="writer"):
+        build_vector_store(config, require_write=True)
+
+
+def test_factory_selects_direct_vector_reader():
+    config = _config(vector_type="pgvector_direct")
+
+    assert isinstance(build_vector_store(config), LegacyDirectVectorStore)
+    with pytest.raises(ConfigError, match="writer"):
+        build_vector_store(config, require_write=True)