fix: clarify memory selection semantics
This commit is contained in:
@@ -215,21 +215,21 @@ Prerequisite: Phase 1 closed.
|
||||
allow_empty:true)`. Rules: at most **5** candidates; ONLY the 3 reusable types
|
||||
(`concept_clarified`, `table_promoted`, `table_excluded`) — query-specific
|
||||
decisions (`question_rewritten`, `sql_approved`, …) are NOT transferable, never
|
||||
propose them. Each option carries `mem_id:"mem-<id>"` plus `type`/`subject`/
|
||||
`rationale`. Selected options are applied (register the decision citing the
|
||||
`mem_id` in the rationale); deselected ones are recorded as `memory_rejected` by
|
||||
the gate (so the next `tht memory search --session` won't re-propose them). The
|
||||
checklist starts pre-selected with the recommended memories. With `allow_empty:true`
|
||||
an empty selection is accepted (no memory applied; deselected still recorded) and
|
||||
the phase advances — no separate gate.
|
||||
propose them. Each option carries `type`/`subject`/`rationale`; cite the source
|
||||
memory id (`mem-<id>`) in its rationale when applying it. Every option describes a
|
||||
candidate memory; never create an opposite "do not use" option. Only
|
||||
`recommended:true` options start checked. A
|
||||
deselected candidate is **not applied now**, not rejected, and may be considered
|
||||
again if Phase 2 is reopened. With `allow_empty:true` an empty selection is accepted
|
||||
(no memory applied) and the phase advances — no separate gate.
|
||||
When the memory search returned **zero** candidates, still issue the single
|
||||
`reviewer_decide(multi:true, advance:true, allow_empty:true)` with an empty merito list: the gate
|
||||
detects the empty+advance case, shows the reviewer an info notice ("Nessuna memory
|
||||
riutilizzabile … passo alla fase successiva") and auto-advances F2 — it does NOT present
|
||||
an empty checklist, and you do NOT add a separate `reviewer_confirm kind:"phase"`.
|
||||
4. Closing: if memories were applied or rejected (substantive decisions), `advance:true`
|
||||
no-ops — close with `reviewer_confirm kind:"phase"`. Only a truly empty memory phase
|
||||
(nothing applied, nothing rejected) auto-advances via `advance:true`.
|
||||
4. Closing: if one or more memories were applied (substantive decisions), `advance:true`
|
||||
no-ops — close with `reviewer_confirm kind:"phase"`. If none is applied, F2
|
||||
auto-advances via `advance:true`.
|
||||
5. Memories are promoted at the END of the workflow (Phase 8, the
|
||||
`reviewer_memory_promote` gate) — never promote from here, never run
|
||||
`tht memory promote`/`save-one` yourself (the gate blocks them).
|
||||
|
||||
@@ -24,14 +24,13 @@ Rules:
|
||||
(e.g. `question_rewritten`, `sql_approved`) are NOT to be proposed: they don't
|
||||
transfer to other questions.
|
||||
- All candidate memories go in **a single** `reviewer_decide(multi:true,
|
||||
advance:true, allow_empty:true)`: each selected option is applied (register the
|
||||
decision with the appropriate type, citing the memory id in the rationale), each
|
||||
deselected option is **recorded as `memory_rejected` by the gate** (so the next
|
||||
`tht memory search --session` won't re-propose it). To enable this, EVERY memory
|
||||
option MUST carry the field `mem_id:"mem-<id>"` (besides `type`/`subject`/
|
||||
`rationale`). The checklist starts pre-selected with the recommended memories.
|
||||
With `allow_empty:true` an **empty selection is accepted** (no memory applied; the
|
||||
deselected ones are still recorded as rejected) and the phase advances — no
|
||||
advance:true, allow_empty:true)`: every option describes a candidate memory, never
|
||||
an opposite action such as "do not use it". Each selected option is applied
|
||||
(register the decision with the appropriate type, citing the memory id in the
|
||||
rationale). Mark `recommended:true` ONLY on memories proposed for use: those, and
|
||||
only those, start checked. An unchecked memory is **not applied now**; it is not a
|
||||
rejection and may be considered again if Phase 2 is reopened. With `allow_empty:true`
|
||||
an **empty selection is accepted** (no memory applied) and the phase advances — no
|
||||
separate gate.
|
||||
- For "inspect": show the memory's full JSON record in the prose before presenting
|
||||
the checklist, if the reviewer asks.
|
||||
|
||||
Reference in New Issue
Block a user