fix(harness): remediation difetti review — gate↔CLI, D15, D7/D6, D14, robustezza

Implementazione del piano di remediation progressiva sui difetti emersi
dall'analisi dell'harness. Tutto verificato: 214 test Python (incl. L0 su
Postgres reale), 14 test JS del gate, ruff pulito.

Blocco 1 (CRITICA, integrazione gate↔CLI):
- phase advance: gate usa --auto + exit 6; reviewer_confirm kind:phase fa
  advance esplicito che applica i prerequisiti (prima non avanzava per le
  fasi a conferma umana).
- cte plan riceve i --name dal gate (param names); set-question con id
  posizionale; skill `tht search find`; nuovo comando `tht memory save-one`
  con dedup hash client-side in save_one_memory.

Blocco 2 (D15, stato post-rollback):
- campo `phase` su DecisionRecord + effective_decisions phase-aware per i
  subject "a nome" (cte_approved ecc.); _compute_promotions e finalize sulla
  vista effective; finalize confronta col piano CTE effettivo, non glob;
  `decision add --retracts` + comando `decision retract`.

Blocco 3 (D7 read-only + D6 manifest):
- assert_read_only su tutti e quattro i codepath (direct + REST);
- manifest author/summary/updated_at/updated_by/schema_version popolati +
  helper touch_manifest sulle mutazioni.

Blocco 4-5 (D14a/D14b):
- decision_min_phase data-driven via `emits:` in workflow.yaml;
- formula evidence: status auto, search_formulas, gruppo CLI `tht formula`,
  `search find --kind formula`, load_evidence_dir salta i .sql.md.

Blocco 6 (robustezza):
- taskdoc slice promoted_tables + bound enforced; report escaping/bound +
  rsplit note; filtro kind reader REST/direct; conteggio upserted robusto;
  guard REST run_query non-list; LSH disallineato -> LshIndexError.

Blocco 7 (pulizia):
- dead code gate e KIND_TO_TABLE morto rimossi; doc Postgres-only
  (README + connection.py).

Blocco 0 (parziale): test di compatibilità firma gate↔CLI
(tests/integration). Rinviati: fake-Pi runtime completo, artifact-gate da
disco (#23), parità eligibility REST/direct (#28), unificazione
reserved-labels (#30), memory_rejected da deselezione (#33).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

harness/tht/evidence/formula_store.py

@@ -27,7 +27,9 @@ class ConceptFormula(BaseModel):
     concept: str
     columns: list[str] = []
     sql: str
-    status: Literal["draft", "reviewed"] = "draft"
+    # auto = sintetizzata dal modello (non ancora rivista); draft = bozza umana;
+    # reviewed = approvata da un revisore. (spec §4.7.2: status auto/draft/reviewed)
+    status: Literal["auto", "draft", "reviewed"] = "draft"
     sources: list[str] = []
 
     @property
@@ -81,20 +83,29 @@ def save_formula(root: Path | str, formula: ConceptFormula) -> Path:
     return path
 
 
-def retrieve_formula(root: Path | str, concept: str) -> list[ConceptFormula]:
-    """All formulas for `concept` under <root>/formulas/. Empty list if none (or if
-    the dir is absent). Multiple results mean competing drafts/versions for the same
-    concept -- the caller (gate) lets the reviewer pick."""
-    root = Path(root)
+def _load_all(root: Path) -> list[ConceptFormula]:
     formulas_dir = root / FORMULAS_SUBDIR
     if not formulas_dir.is_dir():
         return []
     out: list[ConceptFormula] = []
     for f in sorted(formulas_dir.glob("*.sql.md")):
         try:
-            formula = ConceptFormula.parse(f.read_text())
+            out.append(ConceptFormula.parse(f.read_text()))
         except ValueError:
             continue  # malformed file: skip, don't crash retrieval
-        if formula.concept == concept:
-            out.append(formula)
     return out
+
+
+def retrieve_formula(root: Path | str, concept: str) -> list[ConceptFormula]:
+    """All formulas matching `concept` exactly under <root>/formulas/. Empty list if
+    none (or if the dir is absent). Multiple results mean competing drafts/versions for
+    the same concept -- the caller (gate) lets the reviewer pick."""
+    return [f for f in _load_all(Path(root)) if f.concept == concept]
+
+
+def search_formulas(root: Path | str, query: str) -> list[ConceptFormula]:
+    """Formulas whose concept contains `query` (case-insensitive). Used by
+    `tht search find --kind formula` (D14b retrieval, §4.7.2): the reviewer searches a
+    concept term and gets the candidate formulas to approve before they reach the CTE."""
+    q = query.strip().lower()
+    return [f for f in _load_all(Path(root)) if q in f.concept.lower()]

harness/tht/evidence/model.py

@@ -58,5 +58,9 @@ def load_evidence_dir(root: Path) -> list[EvidenceDoc]:
     for f in sorted(root.rglob("*.md")):
         if f.name.upper().startswith("README"):
             continue
+        # I file formula (concept->SQL, frontmatter diverso) vivono sotto formulas/ con
+        # estensione .sql.md: non sono EvidenceDoc, li gestisce formula_store (D14b).
+        if f.name.endswith(".sql.md"):
+            continue
         docs.append(EvidenceDoc.parse(f.read_text(), path=f))
     return docs