fix(core): preserve adapter command contracts
This commit is contained in:
@@ -43,18 +43,18 @@ def test_solved_kind_maps_to_memory_table():
|
||||
def test_save_upserts_single_row_into_memory_table():
|
||||
writer = MagicMock()
|
||||
writer.existing_hashes.return_value = {}
|
||||
writer.upsert_records.return_value = 1
|
||||
writer.upsert.return_value = 1
|
||||
embedder = MagicMock()
|
||||
embedder.embed_documents.return_value = [[0.1] * 8]
|
||||
|
||||
assert save_solved_question(_rec(), writer=writer, embedder=embedder) == 1
|
||||
assert save_solved_question(_rec(), store=writer, embedder=embedder) == 1
|
||||
writer.sync.assert_not_called()
|
||||
table, rows = writer.upsert_records.call_args[0]
|
||||
table, rows = writer.upsert.call_args[0]
|
||||
assert table == "memory"
|
||||
assert len(rows) == 1
|
||||
assert rows[0]["record_key"] == "solved:s1"
|
||||
assert rows[0]["metadata"]["kind"] == SOLVED_KIND
|
||||
assert rows[0]["metadata"]["sql"].startswith("SELECT")
|
||||
assert rows[0].record.id == "solved:s1"
|
||||
assert rows[0].record.kind == SOLVED_KIND
|
||||
assert rows[0].record.metadata["sql"].startswith("SELECT")
|
||||
|
||||
|
||||
def test_save_skips_when_question_and_sql_unchanged():
|
||||
@@ -62,9 +62,9 @@ def test_save_skips_when_question_and_sql_unchanged():
|
||||
writer = MagicMock()
|
||||
writer.existing_hashes.return_value = {r.id: _solved_hash(r)}
|
||||
embedder = MagicMock()
|
||||
assert save_solved_question(r, writer=writer, embedder=embedder) == 0
|
||||
assert save_solved_question(r, store=writer, embedder=embedder) == 0
|
||||
embedder.embed_documents.assert_not_called()
|
||||
writer.upsert_records.assert_not_called()
|
||||
writer.upsert.assert_not_called()
|
||||
|
||||
|
||||
def test_sql_change_alone_triggers_reupsert():
|
||||
@@ -72,7 +72,7 @@ def test_sql_change_alone_triggers_reupsert():
|
||||
new = _rec(sql="SELECT 1") # stessa domanda, SQL diverso
|
||||
writer = MagicMock()
|
||||
writer.existing_hashes.return_value = {old.id: _solved_hash(old)}
|
||||
writer.upsert_records.return_value = 1
|
||||
writer.upsert.return_value = 1
|
||||
embedder = MagicMock()
|
||||
embedder.embed_documents.return_value = [[0.0] * 4]
|
||||
assert save_solved_question(new, writer=writer, embedder=embedder) == 1
|
||||
assert save_solved_question(new, store=writer, embedder=embedder) == 1
|
||||
|
||||
Reference in New Issue
Block a user