fix(evidence): enforce active vector generations
This commit is contained in:
@@ -59,3 +59,24 @@ Live pgvector integration needs Docker or an authorized local pgvector endpoint.
|
||||
strategy is logical isolation rather than destructive cleanup because the shared `VectorStore`
|
||||
port intentionally exposes no delete/transaction API; unreachable failed generations can be
|
||||
garbage-collected by a future maintenance job.
|
||||
|
||||
## Review integration wave
|
||||
|
||||
Added an enforceable `metadata_filter` vector-port contract and capability flags. Direct pgvector
|
||||
places exact Evidence generation/document predicates in SQL before `LIMIT`; HTTP sends the same
|
||||
filter to the RPC and deliberately does not use the legacy 404 fallback. The reader RPC script now
|
||||
validates and applies that filter. Normal Evidence search and search-pack use an ACTIVE-aware
|
||||
searcher that groups active documents by generation, executes complete server-filtered searches,
|
||||
and merges the results.
|
||||
|
||||
Added exact-generation Evidence cleanup to direct and HTTP writers plus the allowlisted writer RPC.
|
||||
Pipeline failures compensate both staged filesystem state and vector writes; cleanup failures stay
|
||||
sanitized and ACTIVE filtering remains the exposure boundary. Corpus-present session artifact
|
||||
resolution now fails closed on corrupt/missing ACTIVE rather than falling through to source files.
|
||||
|
||||
Focused review-wave verification: 45 passed, scoped Ruff clean. A mocked REST regression proves
|
||||
the exact filter payload and fail-closed legacy 404 behavior.
|
||||
|
||||
Still outstanding from the expanded review request: Task-4 JobRunner stage-by-stage integration,
|
||||
published-generation retention/garbage collection, same-fd `dirfd` materialized-file reads, and
|
||||
live local pgvector integration could not be completed in this wave.
|
||||
|
||||
Reference in New Issue
Block a user