mptyl/ThothII
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: reject duplicate legacy DWH records

Browse Source
This commit is contained in:
User
2026-08-21 01:52:02 +02:00
parent b1079bda21
commit 943f809d01
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/dwh-auth/internal/registry/store.go
+1 -1
View File
@@ -516,7 +516,7 @@ func validateLegacyMultiplicity(active, revoked []storedRecord) error {
revokedCount++ revokedCount++
} }
} }
if activeCount > 1 || revokedCount > 1 || activeCount+revokedCount > 2 { if activeCount > 1 || revokedCount > 1 || activeCount+revokedCount > 1 {
return integrity(errors.New("multiple legacy records")) return integrity(errors.New("multiple legacy records"))
} }
return nil return nil
tools/dwh-auth/internal/registry/store_test.go
+16
View File
@@ -289,6 +289,22 @@ func TestFindLegacyAllowsOneAndRejectsMultipleRecords(t *testing.T) {
t.Fatal("FindLegacy() error = nil, want multiple-legacy integrity refusal") t.Fatal("FindLegacy() error = nil, want multiple-legacy integrity refusal")
} }
}) })
t.Run("active and revoked legacy records", func(t *testing.T) {
root := t.TempDir()
store := openStore(t, root)
legacy := syntheticLegacyRecord()
if err := store.Add(legacy); err != nil {
t.Fatalf("Add() error = %v", err)
}
revokedAt := legacy.CreatedAt.Add(time.Hour)
writeRecord(t, root, StateRevoked, legacy.KeyID+".json", marshalRecord(t, revokedRecord(legacy, revokedAt, "synthetic")), 0o640)
if _, err := store.FindLegacy(); !errors.Is(err, ErrIntegrity) {
t.Fatalf("FindLegacy() error = %v, want ErrIntegrity", err)
}
if err := store.Check(); !errors.Is(err, ErrIntegrity) {
t.Fatalf("Check() error = %v, want ErrIntegrity", err)
}
})
} }
func TestConcurrentAddDoesNotOverwriteAndFindNeverReadsPartialRecord(t *testing.T) { func TestConcurrentAddDoesNotOverwriteAndFindNeverReadsPartialRecord(t *testing.T) {