feat: pin sessions to workspace revisions

backend/src/app.ts

@@ -13,7 +13,7 @@ import { sqlRoutes } from "./routes/sql.js";
 import { metaRoutes, type ListModelsFn } from "./routes/meta.js";
 import { settingsRoutes, effectiveSettings } from "./routes/settings.js";
 import { createPiModelLister } from "./pi/list-models.js";
-import { loadSettings, saveSettings, type Settings } from "./settings/settings-store.js";
+import { loadSettings, type Settings } from "./settings/settings-store.js";
 import { ReadinessManager } from "./runtime/readiness-manager.js";
 import { WorkspaceRegistry } from "./workspaces/registry.js";
 import { createProductionWorkspaceDiagnoser } from "./workspaces/diagnostics.js";
@@ -72,28 +72,8 @@ export function buildApp(config: AppConfig, deps?: BuildAppDeps): FastifyInstanc
   };
   const getSettings = async (principal: PrincipalContext): Promise<Settings> => {
     if (deps?.getSettings) return await deps.getSettings(principal);
-    const runner = runnerFor(principal);
-    // The real runner persists preferences through the harness repository. The file fallback
-    // only keeps older isolated route tests and externally injected runners compatible.
-    if (typeof runner.preferencesGet === "function") {
-      const stored = await runner.preferencesGet() as Settings;
-      if (Object.keys(stored).length === 0) {
-        const seeded = effectiveSettings(config, loadSettings(config));
-        await runner.preferencesSet(seeded);
-        return seeded;
-      }
-      return effectiveSettings(config, stored);
-    }
     return effectiveSettings(config, loadSettings(config));
   };
-  const saveUserSettings = async (principal: PrincipalContext, settings: Settings): Promise<void> => {
-    const runner = runnerFor(principal);
-    if (typeof runner.preferencesSet === "function") {
-      await runner.preferencesSet(settings);
-      return;
-    }
-    saveSettings(config, settings);
-  };
 
   const authenticate = authPreHandler(config.authMode);
   app.addHook("preHandler", async (req, reply) => {
@@ -105,13 +85,13 @@ export function buildApp(config: AppConfig, deps?: BuildAppDeps): FastifyInstanc
   app.get("/health/dwh", async () => tht.dbPing());
   app.get("/me", async (req) => getPrincipal(req));
   sessionRoutes(app, {
-    mgr, tht: tht as ThtRunner, hub, getSettings, readiness, listModels,
+    mgr, tht: tht as ThtRunner, hub, getSettings, readiness, listModels, workspaceRegistry,
     dwhPrecheck: config.dwhPrecheck,
   });
   sqlRoutes(app, { tht: tht as ThtRunner, getSettings });
   metaRoutes(app, { harnessDir: config.harnessDir, listModels });
   workspaceRoutes(app, { registry: workspaceRegistry, config: config.workspaceRegistry, diagnose: workspaceDiagnoser });
-  settingsRoutes(app, { cfg: config, listModels, getSettings, saveSettings: saveUserSettings });
+  settingsRoutes(app, { cfg: config, listModels, getSettings });
 
   return app;
 }