fix: harden reviewer workflow and memory handling

harness/tests/test_memory_metadata.py

@@ -13,9 +13,9 @@ from tht.memory import MemoryRecord, memory_vector_records
 def _record(**kw) -> MemoryRecord:
     base = dict(
         id="mem-x", ts=datetime(2025, 1, 1), session_id="s", decision_seq=1,
-        type="table_promoted", subject="dim_pazienti", detail="promossa",
+        type="concept_clarified", subject="paziente attivo", detail="flag_attivo = TRUE",
         rationale="perche' serve", question_context="dammi pazienti",
-        tables=["t"], concepts=[],
+        tables=[], concepts=["paziente attivo"],
     )
     base.update(kw)
     return MemoryRecord(**base)
@@ -23,17 +23,17 @@ def _record(**kw) -> MemoryRecord:
 
 def test_memory_vector_record_has_subject_detail_rationale_in_metadata():
     vr = memory_vector_records([_record()])[0]
-    assert vr.metadata["subject"] == "dim_pazienti"
-    assert vr.metadata["detail"] == "promossa"
+    assert vr.metadata["subject"] == "paziente attivo"
+    assert vr.metadata["detail"] == "flag_attivo = TRUE"
     assert vr.metadata["rationale"] == "perche' serve"
 
 
 def test_memory_vector_record_metadata_keeps_existing_fields():
     vr = memory_vector_records([_record()])[0]
     # i campi che gia' c'erano restano (backward compat)
-    assert vr.metadata["type"] == "table_promoted"
-    assert vr.metadata["tables"] == ["t"]
-    assert vr.metadata["concepts"] == []
+    assert vr.metadata["type"] == "concept_clarified"
+    assert vr.metadata["tables"] == []
+    assert vr.metadata["concepts"] == ["paziente attivo"]
     assert vr.metadata["session_id"] == "s"
 
 
@@ -62,6 +62,6 @@ def test_save_one_memory_preserves_subject_through_upsert_row():
     save_one_memory([_record(decision_seq=1)], decision_seq=1, store=writer, embedder=embedder)
     row = writer.upsert.call_args[0][1][0]
     md = row.record.metadata
-    assert md["subject"] == "dim_pazienti"
-    assert md["detail"] == "promossa"
+    assert md["subject"] == "paziente attivo"
+    assert md["detail"] == "flag_attivo = TRUE"
     assert md["rationale"] == "perche' serve"