mptyl/ThothII
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: reject reserved Git HEAD branch

Browse Source
This commit is contained in:
marcopan
2026-08-03 21:22:08 +02:00
parent cc951d8073
commit 6434c9c4e1
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/config.ts
+1
View File
@@ -45,6 +45,7 @@ function refSafeGitBranch(value: string): string {
const branch = requiredRegistryValue(value, "branch"); const branch = requiredRegistryValue(value, "branch");
if ( if (
branch === "@" branch === "@"
|| branch === "HEAD"
|| branch.startsWith("-") || branch.startsWith("-")
|| branch.startsWith("/") || branch.startsWith("/")
|| branch.endsWith("/") || branch.endsWith("/")
backend/test/workspaces-config.test.ts
+5
View File
@@ -53,6 +53,11 @@ test("rejects ref-unsafe Git branches", () => {
} }
}); });
test("rejects the reserved HEAD branch without rejecting lowercase head", () => {
expect(() => loadConfig({ THT_WORKSPACE_GIT_BRANCH: "HEAD" })).toThrow(/branch/i);
expect(loadConfig({ THT_WORKSPACE_GIT_BRANCH: "head" }).workspaceRegistry.branch).toBe("head");
});
test("rejects control characters in installation IDs", () => { test("rejects control characters in installation IDs", () => {
for (const codePoint of [...Array(0x20).keys(), ...Array(0x21).keys()].map((code, index) => ( for (const codePoint of [...Array(0x20).keys(), ...Array(0x21).keys()].map((code, index) => (
index < 0x20 ? code : code + 0x7f index < 0x20 ? code : code + 0x7f