Chiusura fase di ristrutturazione e modularizzazione del workflow per favorire sviluppo modulare

harness/tests/test_dwh_preprocess_job.py

@@ -6,13 +6,16 @@ from typer.testing import CliRunner
 
 from tht.cli import app
 from tht.config import load_config
-from tht.jobs.dwh_pipeline import DwhPreprocessPipeline
-from tht.jobs.dwh_pipeline import active_generation_dir, config_dwh_binding, fingerprint
-from tht.jobs.dwh_pipeline import resolve_dwh_snapshot
-from tht.jobs.dwh_pipeline import lease_dwh_snapshot
+from tht.jobs.dwh_pipeline import (
+    DwhPreprocessPipeline,
+    active_generation_dir,
+    config_dwh_binding,
+    fingerprint,
+    lease_dwh_snapshot,
+    resolve_dwh_snapshot,
+)
 from tht.jobs.locking import _lock_name
 
-
 FP = "sha256:" + hashlib.sha256(b"test").hexdigest()
 
 
@@ -104,9 +107,8 @@ def test_unowned_reads_fail_closed_without_creating_any_files(tmp_path):
     cfg = snapshot_config(tmp_path)
     with pytest.raises(Exception, match="not initialized"):
         resolve_dwh_snapshot(cfg)
-    with pytest.raises(Exception, match="not initialized"):
-        with lease_dwh_snapshot(cfg):
-            pass
+    with pytest.raises(Exception, match="not initialized"), lease_dwh_snapshot(cfg):
+        pass
     assert not (tmp_path / ".tht-dwh").exists()
 
 
@@ -125,7 +127,7 @@ def test_writer_claim_allows_only_lock_and_empty_generations(tmp_path):
         pipeline = DwhPreprocessPipeline(
             workspace_id="demo", workspace_root=root.parent,
             config_fingerprint=FP, input_fingerprint=FP,
-            introspect=lambda output: calls.append("called"),
+            introspect=lambda output, calls=calls: calls.append("called"),
             build_lsh=lambda physical, output: None,
         )
         with pytest.raises(Exception, match="unbound"):
@@ -188,6 +190,7 @@ def test_owner_publication_remains_on_locked_root_when_path_is_swapped(
     monkeypatch, tmp_path,
 ):
     import pytest
+
     import tht.jobs.dwh_pipeline as module
 
     real_replace = module.os.replace
@@ -211,7 +214,7 @@ def test_owner_publication_remains_on_locked_root_when_path_is_swapped(
         introspect=lambda output: (_ for _ in ()).throw(AssertionError("callback called")),
         build_lsh=lambda physical, output: None,
     )
-    with pytest.raises(Exception):
+    with pytest.raises(Exception, match="root"):
         pipeline.run()
     assert swapped
     assert (moved / "OWNER.json").is_file()
@@ -394,7 +397,7 @@ def test_missing_active_with_generations_and_symlink_owner_marker_fail_closed(tm
 def _capture_error(operation):
     try:
         return operation()
-    except Exception as error:
+    except Exception as error:  # noqa: BLE001 - helper returns the exact injected failure
         return error
 
 
@@ -513,6 +516,7 @@ def test_unsafe_lsh_filename_is_rejected(tmp_path):
 
 def test_active_fsync_failure_restores_previous_pointer(monkeypatch, tmp_path):
     import os
+
     import tht.jobs.dwh_pipeline as module
     def build(physical, output):
         for name in ("demo_lsh.pkl", "demo_minhashes.pkl", "demo_meta.json"):
@@ -585,7 +589,7 @@ def test_snapshot_root_swap_after_lease_never_reads_replacement(monkeypatch, tmp
     try:
         with lease_dwh_snapshot(snapshot_config(tmp_path)) as snapshot:
             assert snapshot.physical.read_text() == "trusted"
-    except Exception as error:
+    except Exception as error:  # noqa: BLE001 - either safe refusal path is acceptable
         assert "ACTIVE" in str(error) or "root" in str(error)
     assert swapped
     assert (replacement / "sentinel").read_text() == "replacement-secret"
@@ -623,7 +627,9 @@ def test_snapshot_copies_each_validated_artifact_once_without_reopen(monkeypatch
 def test_reconcile_mismatch_closes_active_generation_fd(monkeypatch, tmp_path):
     import os
     from types import SimpleNamespace
+
     import pytest
+
     import tht.jobs.dwh_pipeline as module
 
     pipeline = DwhPreprocessPipeline(
@@ -637,7 +643,7 @@ def test_reconcile_mismatch_closes_active_generation_fd(monkeypatch, tmp_path):
     real_active = module._active_generation_fd
 
     def mismatched_active(root_fd, binding):
-        generation, generation_fd = real_active(root_fd, binding)
+        _generation, generation_fd = real_active(root_fd, binding)
         return "f" * 32, generation_fd
 
     monkeypatch.setattr(module, "_active_generation_fd", mismatched_active)
@@ -676,9 +682,10 @@ def test_pipeline_releases_materialized_snapshot_after_every_run(tmp_path):
 
 
 def test_corrupt_resume_checkpoint_releases_materialized_snapshot(tmp_path):
-    import tht.jobs.dwh_pipeline as module
     import pytest
 
+    import tht.jobs.dwh_pipeline as module
+
     pipeline = DwhPreprocessPipeline(
         workspace_id="demo", workspace_root=tmp_path,
         config_fingerprint=FP, input_fingerprint=FP,
@@ -699,9 +706,10 @@ def test_corrupt_resume_checkpoint_releases_materialized_snapshot(tmp_path):
 
 
 def test_job_spec_construction_failure_releases_materialized_snapshot(monkeypatch, tmp_path):
-    import tht.jobs.dwh_pipeline as module
     import pytest
 
+    import tht.jobs.dwh_pipeline as module
+
     pipeline = DwhPreprocessPipeline(
         workspace_id="demo", workspace_root=tmp_path,
         config_fingerprint=FP, input_fingerprint=FP,