test: align semantic index doc verifier

2026-08-08 21:22:51 +02:00
parent bed43c747e
commit 5c12d9bb79
3 changed files with 71 additions and 4 deletions
@@ -115,6 +115,36 @@ Evidence:
 git diff --check
 ```

+## Fix round 4/5 — 2026-08-08
+
+Addressed reviewer finding:
+
+- Eliminated semantic-index verifier/test contract drift by extracting the production
+  semantic-index ownership row matcher into `semantic_index_relationship_spec` and reusing it in
+  the fixture-level paraphrase, omission, and scattered-token checks.
+- Kept the relationship constrained to one structured Markdown table row via
+  `verify_markdown_table_relationships`; the scattered-token fixture still removes the row and
+  appends the same words outside the table, where it must be rejected.
+- Added a direct regression that copies the repository docs into an isolated root, applies the
+  accepted paraphrase “A workspace keeps exactly one Qdrant collection reserved for itself”, and
+  runs that root's actual `scripts/verify-workspace-install-docs.sh --fixtures-only` instead of a
+  separate temporary spec.
+
+Observed RED before the fix:
+
+```text
+production verifier rejected the accepted semantic-index paraphrase
+local workspace manual: missing relationship in 'Semantic index ownership contract': {'scope': 'workspace semantic index', 'ownership rule': '(each|one|single).*(workspace).*(single|one).*(Qdrant).*(collection)|(each workspace reserves a single qdrant collection)', 'isolation rule': 'schema.*evidence.*memory.*(one|that).*(collection).*(kind|payload)'}
+```
+
+Evidence:
+
+```sh
+./scripts/test-verify-workspace-install-docs.sh
+./scripts/verify-workspace-install-docs.sh --fixtures-only
+git diff --check
+```
+
 Observed RED during this round:

 ```text