mptyl/ThothII
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(ci): isolate npm release configuration

Browse Source
This commit is contained in:
marcopan
2026-08-25 16:47:56 +02:00
parent 3e106d5262
commit 5b6fec939a
2 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/test-verify-schema-v3-only.sh
+6
View File
@@ -581,9 +581,15 @@ grep -Fq 'export PYTHONDONTWRITEBYTECODE=1' "$project_root/scripts/verify-schema
|| fail "release wrapper does not disable Python bytecode"
release_plan="$($gate_bash "$project_root/scripts/verify-schema-v3-only-release.sh" --dry-run)"
first_command="$(printf '%s\n' "$release_plan" | sed -n '1p')"
user_config_command="$(printf '%s\n' "$release_plan" | sed -n '2p')"
global_config_command="$(printf '%s\n' "$release_plan" | sed -n '3p')"
bootstrap_command="$(printf '%s\n' "$release_plan" | sed -n '4p')"
[[ "$first_command" == 'export PYTHONDONTWRITEBYTECODE=1' ]] \
|| fail "release dry-run does not print the Python bytecode export"
[[ "$user_config_command" == 'export NPM_CONFIG_USERCONFIG=<private-empty-user-config>' ]] \
|| fail "release dry-run does not isolate npm user configuration"
[[ "$global_config_command" == 'export NPM_CONFIG_GLOBALCONFIG=<private-empty-global-config>' ]] \
|| fail "release dry-run does not isolate npm global configuration"
[[ "$bootstrap_command" == '/bin/bash scripts/verify-schema-v3-only.sh --bootstrap-trust-only' ]] \
|| fail "release plan does not bootstrap trust before npm"
printf '%s\n' "$release_plan" | grep -Fq '(cd backend && npm ci --ignore-scripts)' \
scripts/verify-schema-v3-only-release.sh
+9 -4
View File
@@ -3,14 +3,12 @@
# dependencies come from backend/package-lock.json and dist comes from a clean build.
set -euo pipefail
export PYTHONDONTWRITEBYTECODE=1
export NPM_CONFIG_USERCONFIG=/dev/null
export NPM_CONFIG_GLOBALCONFIG=/dev/null
root="$(cd "$(dirname "$0")/.." && pwd -P)"
if [[ ${1:-} == --dry-run ]]; then
cat <<'EOF'
export PYTHONDONTWRITEBYTECODE=1
export NPM_CONFIG_USERCONFIG=/dev/null
export NPM_CONFIG_GLOBALCONFIG=/dev/null
export NPM_CONFIG_USERCONFIG=<private-empty-user-config>
export NPM_CONFIG_GLOBALCONFIG=<private-empty-global-config>
/bin/bash scripts/verify-schema-v3-only.sh --bootstrap-trust-only
(cd backend && npm ci --ignore-scripts)
(cd backend && npm run build)
@@ -21,6 +19,13 @@ EOF
exit 0
fi
[[ $# -eq 0 ]] || { echo "usage: $0 [--dry-run]" >&2; exit 2; }
release_tmp="$(mktemp -d "${TMPDIR:-/tmp}/thoth-v3-release.XXXXXX")"
trap 'rm -rf "$release_tmp"' EXIT HUP INT TERM
: >"$release_tmp/npm-userconfig"
: >"$release_tmp/npm-globalconfig"
chmod 0600 "$release_tmp/npm-userconfig" "$release_tmp/npm-globalconfig"
export NPM_CONFIG_USERCONFIG="$release_tmp/npm-userconfig"
export NPM_CONFIG_GLOBALCONFIG="$release_tmp/npm-globalconfig"
/bin/bash "$root/scripts/verify-schema-v3-only.sh" --bootstrap-trust-only
(cd "$root/backend" && npm ci --ignore-scripts)
(cd "$root/backend" && npm run build)