feat: add metadata catalog cleanup commands

2026-08-28 00:37:43 +02:00
parent 79c4c925b5
commit 58ee9cffe4
19 changed files with 942 additions and 66 deletions
@@ -123,3 +123,80 @@ test.skipIf(!dockerAvailable)("PostgreSQL migration enforces one database per wo
    await container.stop();
  }
 }, 60_000);
+
+test.skipIf(!dockerAvailable)("PostgreSQL repository performs scoped metadata cleanup with catalog cascades", async () => {
+  const container = await new PostgreSqlContainer("postgres:17.6-bookworm").start();
+  const db = new Kysely<CatalogDatabase>({
+    dialect: new PostgresDialect({ pool: new Pool({ connectionString: container.getConnectionUri() }) }),
+    plugins: [new CamelCasePlugin()],
+  });
+  try {
+    await upDatabases(db);
+    await upTables(db);
+    await upSchemaSync(db);
+    const repository = new KyselyCatalogRepository(db);
+    const database = await repository.create({
+      workspaceId: "cleanup-test",
+      engine: "postgres",
+      databaseName: "warehouse",
+      schema: "public",
+      binding: { transport: "postgres_direct", host: "db.internal", port: 5432, username: "reader" },
+    });
+    const snapshot: ObservedSchemaSnapshot = {
+      schemaVersion: 1,
+      capabilities: { tables: "available", columns: "available", relationships: "available" },
+      tables: [
+        { name: "patients", sourceComment: null },
+        { name: "visits", sourceComment: null },
+      ],
+      columns: [
+        { tableName: "patients", name: "id", ordinalPosition: 1, dataType: "bigint", isNullable: false, defaultExpression: null, primaryKeyPosition: 1, sourceComment: null },
+        { tableName: "patients", name: "name", ordinalPosition: 2, dataType: "text", isNullable: true, defaultExpression: null, primaryKeyPosition: null, sourceComment: null },
+        { tableName: "visits", name: "id", ordinalPosition: 1, dataType: "bigint", isNullable: false, defaultExpression: null, primaryKeyPosition: 1, sourceComment: null },
+        { tableName: "visits", name: "patient_id", ordinalPosition: 2, dataType: "bigint", isNullable: false, defaultExpression: null, primaryKeyPosition: null, sourceComment: null },
+      ],
+      relationships: [{
+        constraintName: "visits_patient_id_fkey",
+        sourceTableName: "visits",
+        targetTableName: "patients",
+        updateRule: "NO ACTION",
+        deleteRule: "CASCADE",
+        deferrable: false,
+        initiallyDeferred: false,
+        columns: [{ position: 1, sourceColumnName: "patient_id", targetColumnName: "id" }],
+      }],
+    };
+    await repository.applySchemaSync(database.id, database.version, "all", [], snapshot);
+    const patients = (await repository.listTables(database.id)).find((table) => table.name === "patients")!;
+
+    expect(await repository.deleteTableMetadata(database.id, [patients.id], "relationships"))
+      .toEqual({ tables: 0, columns: 0, relationships: 1 });
+    expect(await repository.listRelationships(database.id)).toEqual([]);
+    expect(await repository.listColumns(database.id, patients.id)).toHaveLength(2);
+    expect((await repository.get(database.id))?.schemaSyncedVersion).toBeUndefined();
+
+    await repository.applySchemaSync(database.id, database.version, "relationships", [], snapshot);
+    expect(await repository.deleteTableMetadata(database.id, [patients.id], "columns"))
+      .toEqual({ tables: 0, columns: 2, relationships: 0 });
+    expect(await repository.listColumns(database.id, patients.id)).toEqual([]);
+    expect(await repository.listRelationships(database.id)).toMatchObject([
+      { constraintName: "visits_patient_id_fkey", columns: [] },
+    ]);
+
+    await repository.applySchemaSync(database.id, database.version, "columns", [patients.id], snapshot);
+    await repository.applySchemaSync(database.id, database.version, "relationships", [], snapshot);
+    expect(await repository.deleteDatabaseMetadata([
+      database.id,
+      "99999999-9999-4999-8999-999999999999",
+    ], "tables")).toBeUndefined();
+    expect(await repository.listTables(database.id)).toHaveLength(2);
+    expect(await repository.deleteDatabaseMetadata([database.id], "tables"))
+      .toEqual({ tables: 2, columns: 4, relationships: 1 });
+    expect(await repository.get(database.id)).toBeDefined();
+    expect(await repository.listTables(database.id)).toEqual([]);
+    expect(await repository.listRelationships(database.id)).toEqual([]);
+  } finally {
+    await db.destroy();
+    await container.stop();
+  }
+}, 60_000);