fix(adapter): close final foundation review

harness/tests/test_vector_port_contract.py

@@ -1,13 +1,16 @@
+from dataclasses import FrozenInstanceError
 from unittest.mock import MagicMock
 
 import pytest
 
 from tht.adapters.vector.thoth_http import ThothHttpVectorStore
+from tht.adapters.vector.legacy_direct import LegacyDirectVectorStore
 from tht.evidence.model import EvidenceDoc
 from tht.ports.vector import (
     VectorHit,
     VectorRecord,
     VectorStore,
+    VectorReadUnavailable,
     VectorWriteRecord,
     VectorWriteUnavailable,
 )
@@ -24,6 +27,25 @@ def test_http_store_reports_reader_without_writer():
         store.upsert("memory", [])
 
 
+def test_http_store_supports_writer_without_reader():
+    writer = MagicMock()
+    store = ThothHttpVectorStore(reader=None, writer=writer, expected_dimension=768)
+
+    assert store.capabilities.search is False
+    assert store.capabilities.existing_hashes is True
+    assert store.capabilities.upsert is True
+    with pytest.raises(VectorReadUnavailable):
+        store.search(["memory"], [0.1], limit=1)
+
+
+@pytest.mark.parametrize("limit", [True, False, 1.0, 0, -1])
+def test_http_search_requires_a_strict_positive_integer_limit(limit):
+    store = ThothHttpVectorStore(reader=MagicMock(), writer=None)
+
+    with pytest.raises(ValueError, match="positive integer"):
+        store.search(["memory"], [0.1], limit=limit)
+
+
 def test_http_store_keeps_reader_and_writer_operations_separate():
     reader = MagicMock()
     reader.search_similar.return_value = [
@@ -139,10 +161,19 @@ def test_vector_contract_is_exported_from_public_packages():
     from tht.adapters.vector import ThothHttpVectorStore as PublicHttpStore
     from tht.ports import VectorStore as PublicVectorStore
     from tht.ports import VectorWriteRecord as PublicVectorWriteRecord
+    from tht.ports import VectorReadUnavailable as PublicVectorReadUnavailable
 
     assert PublicHttpStore is ThothHttpVectorStore
     assert PublicVectorStore is VectorStore
     assert PublicVectorWriteRecord is VectorWriteRecord
+    assert PublicVectorReadUnavailable is VectorReadUnavailable
+
+    capabilities = store_capabilities = ThothHttpVectorStore(
+        reader=MagicMock(), writer=None
+    ).capabilities
+    assert capabilities.search is True
+    with pytest.raises(FrozenInstanceError):
+        store_capabilities.search = False
 
 
 def test_http_health_uses_reader_list_tables_and_reports_failure():
@@ -154,3 +185,66 @@ def test_http_health_uses_reader_list_tables_and_reports_failure():
     health = store.health()
     assert health.ok is False
     assert health.detail == "offline"
+
+
+def test_http_health_reports_read_write_and_dimension_status_independently():
+    reader = MagicMock()
+    reader.list_tables.return_value = [
+        {"table_name": "memory", "vector_dimensions": 768}
+    ]
+    writer = MagicMock()
+    writer.list_tables.return_value = [
+        {"table_name": "memory", "vector_dimensions": 768}
+    ]
+    store = ThothHttpVectorStore(reader, writer, expected_dimension=768)
+
+    health = store.health()
+    assert health.ok is True
+    assert health.read_configured is True
+    assert health.read_reachable is True
+    assert health.write_configured is True
+    assert health.write_reachable is True
+    assert health.expected_dimension == 768
+    assert health.observed_dimensions == (768,)
+    assert health.dimension_compatible is True
+
+
+def test_http_health_does_not_hide_writer_failure_behind_reader_success():
+    reader = MagicMock()
+    reader.list_tables.return_value = []
+    writer = MagicMock()
+    writer.list_tables.side_effect = RuntimeError("writer offline")
+    store = ThothHttpVectorStore(reader, writer, expected_dimension=768)
+
+    health = store.health()
+    assert health.ok is False
+    assert health.read_reachable is True
+    assert health.write_reachable is False
+    assert health.write_detail == "writer offline"
+    assert health.dimension_compatible is None
+
+
+def test_http_health_covers_read_only_and_write_only_configuration():
+    reader = MagicMock()
+    reader.list_tables.return_value = [{"vector_dimensions": 384}]
+    read_health = ThothHttpVectorStore(reader, None, expected_dimension=768).health()
+    assert read_health.ok is False
+    assert read_health.write_configured is False
+    assert read_health.write_reachable is None
+    assert read_health.dimension_compatible is False
+
+    writer = MagicMock()
+    writer.list_tables.return_value = [{"vector_dimensions": 768}]
+    write_health = ThothHttpVectorStore(None, writer, expected_dimension=768).health()
+    assert write_health.ok is True
+    assert write_health.read_configured is False
+    assert write_health.read_reachable is None
+    assert write_health.dimension_compatible is True
+
+
+@pytest.mark.parametrize("limit", [True, False, 1.0, 0, -1])
+def test_legacy_direct_search_requires_a_strict_positive_integer_limit(limit):
+    store = LegacyDirectVectorStore(engine=MagicMock())
+
+    with pytest.raises(ValueError, match="positive integer"):
+        store.search(["memory"], [0.1], limit=limit)