refactor(workflow): contract shared core (#33)

harness/.pi/extensions/gate/__tests__/artifact_contracts.test.js

@@ -7,7 +7,7 @@ const {
   validateCtePlanV2,
   validateCteResultThin,
   validatePhaseSummaryV2,
-} = require("../artifact-contracts.js");
+} = require("../core/artifact-contracts.js");
 
 // --- validateCtePlanV2 (payload A) ------------------------------------------------
 

harness/.pi/extensions/gate/__tests__/builders.test.js

@@ -18,7 +18,7 @@ const {
   buildSchemaLinkingRequest,
   buildJoinReviewRequest,
   withChildLinkage,
-} = require("../builders.js");
+} = require("../core/builders.js");
 
 const GOLDEN = path.join(__dirname, "golden");
 const golden = (name) => JSON.parse(fs.readFileSync(path.join(GOLDEN, name)));

harness/.pi/extensions/gate/__tests__/enrich.test.js

@@ -6,7 +6,7 @@ const {
   enrichCtePlanV2,
   buildCteResultV2,
   enrichPhaseSummaryV2,
-} = require("../enrich.js");
+} = require("../core/enrich.js");
 
 // --- enrichCtePlanV2 --------------------------------------------------------------
 
@@ -202,7 +202,7 @@ test("enrichPhaseSummaryV2 preserves open_questions/checks untouched", () => {
 
 // --- appendLedgerSection -----------------------------------------------------------
 
-const { appendLedgerSection } = require("../enrich.js");
+const { appendLedgerSection } = require("../core/enrich.js");
 
 test("appendLedgerSection appends only the phase's substantive decisions", () => {
   const data = { schema_version: 2, summary: "s", sections: [{ title: "Criteri", items: [] }] };

harness/.pi/extensions/gate/__tests__/gate_memory_promote.test.js

@@ -1,6 +1,8 @@
 const test = require("node:test");
 const assert = require("node:assert");
 const { createMemoryGate } = require("../memory/index.js");
+const { buildMultiselectRequest } = require("../core/builders.js");
+const { isReserved } = require("../core/reserved-labels.mjs");
 const { createFakePi } = require("./fake_pi_runtime.js");
 
 
@@ -74,6 +76,10 @@ test("the public Memory facade owns F8 policy and mutation ordering", async () =
         return null;
       },
     },
+    reviewer: {
+      buildMultiselect: buildMultiselectRequest,
+      isReserved,
+    },
     waitForReviewer: async (runtimeContext, widget) => {
       const response = await runtimeContext.ui.input(JSON.stringify(widget), "");
       return JSON.parse(response);

harness/.pi/extensions/gate/__tests__/gate_memory_selection.test.js

@@ -1,6 +1,8 @@
 const test = require("node:test");
 const assert = require("node:assert");
 const { createMemoryGate } = require("../memory/index.js");
+const { buildMultiselectRequest } = require("../core/builders.js");
+const { isReserved } = require("../core/reserved-labels.mjs");
 const { createFakePi } = require("./fake_pi_runtime.js");
 
 
@@ -71,6 +73,10 @@ function setupRecall(choices) {
         return null;
       },
     },
+    reviewer: {
+      buildMultiselect: buildMultiselectRequest,
+      isReserved,
+    },
     waitForReviewer: async (runtimeContext, widget) => {
       const response = await runtimeContext.ui.input(JSON.stringify(widget), "");
       return JSON.parse(response);

harness/.pi/extensions/gate/__tests__/gate_stringified_params.test.js

@@ -75,7 +75,7 @@ test("prepareReviewerArguments leaves a legacy markdown string artifact.data UNC
 
 test("GATE_CODE_FILES blocks writes to gate extensions, not session artifacts", () => {
   assert.ok(GATE_CODE_FILES.test("harness/.pi/extensions/tht-gate.js"));
-  assert.ok(GATE_CODE_FILES.test(".pi/extensions/reserved-labels.mjs"));
+  assert.ok(GATE_CODE_FILES.test(".pi/extensions/gate/core/reserved-labels.mjs"));
   assert.equal(GATE_CODE_FILES.test("sessions/s1/schema_linking.json"), false);
   assert.equal(GATE_CODE_FILES.test("sessions/s1/sql_final.sql"), false);
 });

harness/.pi/extensions/gate/__tests__/module_boundaries.test.js

@@ -0,0 +1,43 @@
+const test = require("node:test");
+const assert = require("node:assert");
+const { readdirSync, readFileSync } = require("node:fs");
+const { dirname, extname, join, relative, resolve, sep } = require("node:path");
+
+const gateRoot = resolve(__dirname, "..");
+const domainRoots = ["disambiguation", "memory"];
+
+
+function productionFiles(root) {
+  return readdirSync(root, { withFileTypes: true }).flatMap((entry) => {
+    const path = join(root, entry.name);
+    if (entry.isDirectory()) {
+      return entry.name === "__tests__" ? [] : productionFiles(path);
+    }
+    return [".js", ".mjs"].includes(extname(entry.name)) ? [path] : [];
+  });
+}
+
+
+function relativeImports(path) {
+  const source = readFileSync(path, "utf8");
+  return [...source.matchAll(/(?:from\s+|import\s*(?:\(\s*)?|require\s*\(\s*)["'](\.[^"']+)["']/g)]
+    .map((match) => match[1]);
+}
+
+
+test("gate domain modules receive shared behavior as capabilities", () => {
+  for (const domain of domainRoots) {
+    const root = join(gateRoot, domain);
+    for (const path of productionFiles(root)) {
+      const imports = relativeImports(path).map((specifier) =>
+        relative(gateRoot, resolve(dirname(path), specifier)).split(sep).join("/"));
+      const violations = imports.filter((target) =>
+        target !== domain && !target.startsWith(`${domain}/`));
+      assert.deepEqual(
+        violations,
+        [],
+        `${relative(gateRoot, path)} imports gate implementation directly: ${violations.join(", ")}`,
+      );
+    }
+  }
+});

harness/.pi/extensions/gate/__tests__/reserved_labels.test.js

@@ -1,6 +1,6 @@
 const test = require("node:test");
 const assert = require("node:assert");
-const { isReserved, stripReserved } = require("../../reserved-labels.mjs");
+const { isReserved, stripReserved } = require("../core/reserved-labels.mjs");
 
 test("Altro variants (any punctuation/case) are reserved", () => {
   assert.equal(isReserved("Altro — specifica…"), true);