feat: pin sessions to workspace revisions

2026-08-04 05:05:20 +02:00
parent 90894176b6
commit 301db4bd85
14 changed files with 288 additions and 54 deletions
@@ -32,3 +32,29 @@ The unscoped backend suite was also run. The Task 7 code regressions in `test/th
 were fixed; the remaining failures were existing sandbox restrictions on tests that listen on
 `127.0.0.1` (`listen EPERM: operation not permitted` in SSE/e2e health tests), not application
 assertions.
+
+## Review fixes — round 1
+
+- Every new session now resolves `workspaceId` through the registry; an omitted value uses the
+  configured installation default and persists both the resolved ID and revision. Callers cannot
+  bypass revision pinning by supplying a workspace ID.
+- Browser-local preferences now migrate once from the read-only legacy settings response and hold
+  workspace, provider, model, and thinking. Session creation includes those selections, including
+  direct entry points that run before the composer mounts. The frontend no longer `PUT`s shared
+  settings.
+- The settings compatibility endpoint honors a stored installation workspace before falling back
+  to the first workspace configuration.
+- Resume rejects finalized and archived sessions before looking up any pinned snapshot, preserving
+  the read-only response even when a historical snapshot is unavailable.
+
+### Review verification
+
+- RED: the added backend tests failed for omitted-default pinning, read-only resume ordering, and
+  stored-default precedence; the added frontend preference tests failed because preferences were
+  neither stored nor included in session requests.
+- GREEN: `npx vitest run test/tht-runner.test.ts test/routes-sessions.test.ts test/routes-settings.test.ts && npx tsc --noEmit -p .`
+  — 100 tests passed with a clean type check.
+- GREEN: `npx vitest run && npx tsc -b` — 332 frontend tests passed with a clean type check.
+- GREEN: `THT_HOME=/private/tmp/thothii-task7-home .venv/bin/pytest tests/test_session_documents.py tests/test_session_mutations.py -q`
+  — 22 tests passed (one existing testcontainers deprecation warning).
+- `git diff --check` completed cleanly.