fix: resolve admin issue review findings and record verification

2026-09-12 18:24:23 +02:00
parent c7e5f295e6
commit 2d1b714ebe
10 changed files with 85 additions and 46 deletions
@@ -38,5 +38,40 @@ the existing public Pi service and host projection contracts cover OS transport.
 Red tests were observed before adding tabs, restoring list entry, selecting OS tabs,
 projecting the host platform, and shortening navigation labels.

-Verification results and independent Standards/Spec reviews are recorded below when complete.
+- Frontend full Vitest run: 82 files, 677 tests passed.
+- Backend full Vitest run: 108 files passed, one skipped; 1,380 tests passed, 40 existing
+  optional tests skipped. Backend typecheck passed.
+- After review fixes: all five affected frontend suites passed (163 tests, including
+  two new production-mode persisted-navigation regressions); frontend typecheck and
+  production build passed. The existing large-chunk advisory remains.
+- The complete host CLI suite (`go test ./...`) passed across all 21 packages, including
+  the OS model-projection assertion.
+- Strict documentation build passed.
+- Read-only browser QA of actual React pages at 1280, 768 and 390 CSS pixels checked
+  Workspace tabs, Database table space, and Pi height/overflow. Pi's long instructions
+  initially exposed horizontal page overflow at 390 pixels; constrained grid children
+  and narrow definition lists corrected it. Database QA used an empty synthetic catalog;
+  the unit suites exercise populated tables, columns, edits and operation guards.
+- Docker and real-stack Playwright acceptance were not run for this follow-up.
+  The preview is synthetic and read-only, not a deployment or provider smoke test.
+
+## Standards
+
+Initial independent review: one documented ADR conflict and one maintainability
+judgement call. ADR 0020 now records the owner's superseding #29 footer decision.
+Workspace and Pi now share keyboard tab navigation rather than duplicate its switch.
+The independent follow-up review confirmed both findings resolved, with no new regressions.
+
+## Spec
+
+Initial independent review: two P2 findings. Fresh Database entry could still restore
+Tables/Relationships from local storage, and a real-stack test retained the old Admin
+button-label regex. Both were corrected; fresh entry is list-first while in-memory
+navigation is retained when moving between already mounted app surfaces.
+The independent follow-up review confirmed both findings resolved, with no new regressions.
+
+Review summary: Standards 2 findings resolved, 0 outstanding; Spec 2 findings resolved,
+0 outstanding. Both reviews were read-only, relative to the user-approved baseline.
+
 Docker has not been rebuilt for this follow-up; the read-only QA preview uses the changed source.
+No Gitea issue state or remote branch was changed.