mptyl/ThothII
1
0
Fork 0
Code Issues 25 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(frontend): disable 'Altro' Send until non-whitespace text (no empty freetext)

Browse Source 
Backlog T2 from the reviewer-gate-ux review: the Send button on the reserved
"Other — specify" textarea emitted control:freetext with an empty payload when
clicked on an empty/whitespace field. Guard with disabled={!text.trim()}.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
marcopan
2026-07-02 18:52:12 +02:00
co-authored by Claude Opus 4.8
parent 78518210a0
commit 25ab37d0fe
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/widgets/ReservedControls.test.tsx
+14
View File
@@ -21,3 +21,17 @@ test("other reveals a textarea and emits freetext with the typed text", async ()
await userEvent.click(screen.getByRole("button", { name: /send/i }));
expect(onControl).toHaveBeenCalledWith("freetext", "usa la tabella X");
});
test("Send stays disabled until non-whitespace text is entered", async () => {
const onControl = vi.fn();
render(<ReservedControls reserved={["other"]} onControl={onControl} />);
await userEvent.click(screen.getByRole("button", { name: /other — specify/i }));
const send = screen.getByRole("button", { name: /send/i });
expect(send).toBeDisabled();
await userEvent.type(screen.getByRole("textbox"), " ");
expect(send).toBeDisabled();
await userEvent.click(send);
expect(onControl).not.toHaveBeenCalled();
await userEvent.type(screen.getByRole("textbox"), "ok");
expect(send).not.toBeDisabled();
});