docs(auth): record final review fix round 1 evidence
This commit is contained in:
@@ -2,8 +2,8 @@
|
||||
"schema": "thothii-task4-certification-v1",
|
||||
"generated_on": "2026-08-18",
|
||||
"started_at_utc": "2026-08-18T09:26:00Z",
|
||||
"ended_at_utc": "2026-08-18T09:48:36Z",
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"ended_at_utc": "2026-08-18T13:18:56Z",
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"source_immutability": {
|
||||
"status": "PASS",
|
||||
"tracked_changes_after_freeze": false,
|
||||
@@ -15,6 +15,7 @@
|
||||
"task2": "5f9a3ae066a060b43a11a959b60a1efadd1c2425",
|
||||
"task3": "0d8e707533fada938c99eb06f8457150e7ef2b40",
|
||||
"task3_follow_up": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"fix_round_1_source": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"historical_task15_final": "74b062f1a737103524cbe706346cfd65f87cdfd1"
|
||||
},
|
||||
"versions": {
|
||||
@@ -26,39 +27,36 @@
|
||||
"retained_report": ".superpowers/sdd/2026-08-16-thothii-authentication/task-15-report.md",
|
||||
"task4_report": ".superpowers/sdd/2026-08-18-thothii-authentication-remediation/task-4-report.md",
|
||||
"workflow": {
|
||||
"run_id": "32122302381",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32122302381",
|
||||
"run_id": "32141428407",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32141428407",
|
||||
"event": "workflow_dispatch",
|
||||
"head_sha": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"head_sha": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"status": "completed",
|
||||
"conclusion": "failure",
|
||||
"windows_job": {
|
||||
"name": "Windows clone and Compose contract",
|
||||
"job_id": "95665197885",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32122302381/job/95665197885",
|
||||
"job_id": "95724751282",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32141428407/job/95724751282",
|
||||
"conclusion": "failure",
|
||||
"native_step": "Run native Windows retained-capability tests",
|
||||
"native_step_conclusion": "failure",
|
||||
"command": "go test ./internal/safeio ./internal/backup -count=1",
|
||||
"requested_packages": ["internal/safeio", "internal/backup"],
|
||||
"executed_packages": ["internal/safeio", "internal/backup"],
|
||||
"not_executed_packages": ["internal/authstorage"],
|
||||
"focused_tests_observed": [
|
||||
"TestRemoveCanonicalPrivateClaimRetainsParentDuringDeletion",
|
||||
"TestRemoveCanonicalPrivateClaimPreservesOrphan",
|
||||
"TestRestoreLifecycleLockExcludesCompetingTransactionsUntilTerminalCleanup"
|
||||
],
|
||||
"failure_categories": [
|
||||
"safeio retained-capability tests failed with unsafe file",
|
||||
"backup retained-staging tests failed with unsafe file",
|
||||
"backup TestRestoreLifecycleLockExcludesCompetingTransactionsUntilTerminalCleanup timed out after 10m0s",
|
||||
"some backup fixture tests could not read their external-secret declarations"
|
||||
]
|
||||
"native_step_conclusion": "success",
|
||||
"command": "go test ./internal/safeio ./internal/backup ./internal/authstorage -count=1",
|
||||
"requested_packages": ["internal/safeio", "internal/backup", "internal/authstorage"],
|
||||
"executed_packages": ["internal/safeio", "internal/backup", "internal/authstorage"],
|
||||
"not_executed_packages": [],
|
||||
"package_results": {
|
||||
"internal/safeio": "PASS (8.230s)",
|
||||
"internal/backup": "PASS (5.195s)",
|
||||
"internal/authstorage": "PASS (8.383s)"
|
||||
},
|
||||
"failed_step": "Verify Windows clone contract",
|
||||
"failure_category": "baseline_powershell_parser",
|
||||
"failure_detail": "scripts/test-windows-clone-contract.ps1:208 parses $remoteYaml: as an invalid variable reference"
|
||||
},
|
||||
"lf_compose_docs_typescript_job": {
|
||||
"name": "LF, Compose, docs, and TypeScript",
|
||||
"job_id": "95665197839",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32122302381/job/95665197839",
|
||||
"job_id": "95724751205",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32141428407/job/95724751205",
|
||||
"conclusion": "failure",
|
||||
"failed_step": "Verify Compose and installation contracts",
|
||||
"category": "baseline_ci_contract",
|
||||
@@ -67,14 +65,23 @@
|
||||
},
|
||||
"linux_docker_job": {
|
||||
"name": "Linux Docker deployment and rollback",
|
||||
"job_id": "95665197846",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32122302381/job/95665197846",
|
||||
"job_id": "95724751356",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32141428407/job/95724751356",
|
||||
"conclusion": "failure",
|
||||
"failed_step": "Run unified deployment smoke",
|
||||
"category": "infrastructure_prerequisite",
|
||||
"detail": "Task 13 smoke failed before deployment because rg is required",
|
||||
"cleanup": "PASS",
|
||||
"image_manifest": "not_generated"
|
||||
},
|
||||
"windows_docker_startup_job": {
|
||||
"name": "Native Windows Docker Desktop/WSL2 startup",
|
||||
"job_id": "95724752028",
|
||||
"url": "https://github.com/mptyl/ThothII/actions/runs/32141428407/job/95724752028",
|
||||
"status": "NOT_RUN",
|
||||
"classification": "BLOCKED",
|
||||
"workflow_conclusion": "skipped",
|
||||
"reason": "workflow conditions skipped the job; no Windows Docker Desktop/WSL2 command executed"
|
||||
}
|
||||
},
|
||||
"docker_image_evidence": {
|
||||
@@ -85,9 +92,9 @@
|
||||
},
|
||||
"unified_docker_smoke": {
|
||||
"status": "FAIL",
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"run_id": "32122302381",
|
||||
"workflow_job_id": "95665197846",
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"run_id": "32141428407",
|
||||
"workflow_job_id": "95724751356",
|
||||
"manifest": ".artifacts/task-15/unified-docker-images.json",
|
||||
"reason": "workflow attempt stopped before deployment because rg is required",
|
||||
"cleanup": "PASS",
|
||||
@@ -113,10 +120,15 @@
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"evidence": "focused safeio/backup tests, Go race suite, and Unix ancestor-swap coverage"
|
||||
},
|
||||
"windows_stagearchive_retained_capability": {
|
||||
"status": "PASS",
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"evidence": "native Windows backup package passed, including the two-file shared retained-root staging test"
|
||||
},
|
||||
"windows_claim_retained_capability": {
|
||||
"status": "FAIL",
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"evidence": "native Windows workflow step failed"
|
||||
"status": "PASS",
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"evidence": "native Windows safeio and authstorage packages passed concurrent claim/consume coverage"
|
||||
},
|
||||
"workflow_lf_compose_docs_typescript": {
|
||||
"status": "FAIL",
|
||||
@@ -130,7 +142,7 @@
|
||||
},
|
||||
"go_security_build": {
|
||||
"status": "PASS",
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"focused_packages": 3,
|
||||
"race_packages": 18,
|
||||
"focused_test": "PASS",
|
||||
@@ -140,8 +152,8 @@
|
||||
},
|
||||
"windows_cross_compile": {
|
||||
"status": "PASS",
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"focused_test_packages": 2,
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"focused_test_packages": 3,
|
||||
"cli_build": "PASS",
|
||||
"execution": "cross_compile_only_not_native_execution"
|
||||
},
|
||||
@@ -203,8 +215,8 @@
|
||||
},
|
||||
"unified_docker_smoke": {
|
||||
"status": "FAIL",
|
||||
"source_commit": "b31b27e5845ffd3adf311429367319beaba263c7",
|
||||
"workflow_run_id": "32122302381",
|
||||
"source_commit": "10cd66fe6a5b484a4dc569326a228c1c5484a5d4",
|
||||
"workflow_run_id": "32141428407",
|
||||
"reason": "remote workflow attempted the smoke but stopped before deployment because rg is required",
|
||||
"cleanup": "PASS",
|
||||
"image_manifest": "not_generated"
|
||||
@@ -215,29 +227,29 @@
|
||||
"classification": "known_baseline"
|
||||
},
|
||||
"mkdocs_strict": {
|
||||
"status": "FAIL",
|
||||
"classification": "not_reached_after_stop",
|
||||
"status": "NOT_RUN",
|
||||
"classification": "BLOCKED",
|
||||
"historical_status": "FAIL",
|
||||
"historical_warnings": 69
|
||||
},
|
||||
"canonical_install_docs": {
|
||||
"status": "FAIL",
|
||||
"classification": "not_reached_after_stop",
|
||||
"status": "NOT_RUN",
|
||||
"classification": "BLOCKED",
|
||||
"historical_status": "FAIL"
|
||||
},
|
||||
"workspace_install_docs": {
|
||||
"status": "FAIL",
|
||||
"classification": "not_reached_after_stop",
|
||||
"status": "NOT_RUN",
|
||||
"classification": "BLOCKED",
|
||||
"historical_status": "FAIL"
|
||||
},
|
||||
"pi_user_auth_compose": {
|
||||
"status": "FAIL",
|
||||
"classification": "not_reached_after_stop",
|
||||
"status": "NOT_RUN",
|
||||
"classification": "BLOCKED",
|
||||
"historical_status": "FAIL"
|
||||
},
|
||||
"deployment_coupling": {
|
||||
"status": "FAIL",
|
||||
"classification": "not_reached_after_stop",
|
||||
"status": "NOT_RUN",
|
||||
"classification": "BLOCKED",
|
||||
"historical_status": "FAIL"
|
||||
},
|
||||
"l2": {
|
||||
@@ -254,11 +266,11 @@
|
||||
}
|
||||
},
|
||||
"review": {
|
||||
"three_important_findings_closed": false,
|
||||
"verdict": "CHANGES_REQUIRED",
|
||||
"reason": "native Windows retained-capability tests failed; the frozen workflow omits internal/authstorage from its native command"
|
||||
"four_important_findings_closed": true,
|
||||
"verdict": "ADDRESSED",
|
||||
"reason": "the exact-source native Windows step passed safeio, backup, and authstorage; cleanup and deadlock tests are green and the workflow command includes all three packages"
|
||||
},
|
||||
"release_complete": false,
|
||||
"authentication_implementation_complete": false,
|
||||
"authentication_implementation_complete": true,
|
||||
"release_readiness": "FAIL"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user